Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve startup in JavaScript #60

Open
brodycj opened this issue Jan 11, 2017 · 0 comments
Open

Improve startup in JavaScript #60

brodycj opened this issue Jan 11, 2017 · 0 comments

Comments

@brodycj
Copy link

brodycj commented Jan 11, 2017

The requirement to wait for the deviceready event has caused some major confusion and other trouble for people using Ionic 2 and other Angular derivatives with the sqlite plugin. Here are a couple examples:

I think storesafe/cordova-sqlite-storage#594 (comment) by @rodineijf really helps to highlight this problem:

Hi @brodybits, by default the attribution of rootPage on ionic 2 is on declaration of var rootPage. I can solve my problem moving the rootPage attribution to the platformReady on app.component

initializeApp() {
this.platform.ready().then(() => {

  this.rootPage = MyPage;
  StatusBar.styleDefault();
  Splashscreen.hide();
});
}

In contrast I heard that in the React Native there is no requirement to wait for the deviceready event.

I think the solution is to fix cordova.js to prepare the all of the JavaScript from the plugins upon loading and to have cordova.exec put the native calls into a queue until the initialization is confirmed to be completed.

I will take a look at fixing this when I get a chance.

@brodycj brodycj changed the title Drop requirement to wait for deviceready event Improve startup in JavaScript Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant