Android: add try catch around dialog.dismiss() to prevent crashes #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgruenberger , will this PR be merged? |
|
Hi @platov, i created the PR and hope the owner of the repo will merge it.... Best, |
wif70068
approved these changes
May 10, 2024
|
Hi, can i know when this PR will be merged? |
Makiwin
added a commit
to Makiwin/cordova-plugin-inappbrowser
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
many different Android platforms out in the field
Motivation and Context
Resolves #470
Resolves #893
Resolves #1007
Resolves #384
Description
just adds a try catch block
Testing
We tested the change out in the field in a productive environment on 100+ different Android devices
Checklist
(platform)if this change only applies to one platform (e.g.(android))