fixup! fixup! Fix deprecated auto application of () to method invocations

- add coverage comments
- replace String.valueOf call with string interpolation
- replace mixed string (concat + interpolation) with just string interpolation

DAFFODIL-2152

Author: olabusayoT

daffodil-lib/src/main/scala/org/apache/daffodil/lib/Implicits.scala

@@ -28,7 +28,9 @@ import org.apache.daffodil.lib.xml.NS
 object Implicits {
 
   object ImplicitsSuppressUnusedImportWarning {
+    // $COVERAGE-OFF$
     def apply() = if (scala.math.random().isNaN) Assert.impossible()
+    // $COVERAGE-ON$
   }
 
   /**

daffodil-lib/src/main/scala/org/apache/daffodil/lib/TypedEquality.scala

@@ -36,7 +36,9 @@ import org.apache.daffodil.lib.exceptions.Assert
 package object equality {
 
   def EqualitySuppressUnusedImportWarning() = {
+    // $COVERAGE-OFF$
     if (scala.math.random().isNaN) Assert.impossible()
+    // $COVERAGE-ON$
   }
 
   // Convertible types - strongly typed equality

daffodil-propgen/src/main/scala/org/apache/daffodil/propGen/PropertyGenerator.scala

@@ -762,7 +762,7 @@ import org.apache.daffodil.lib.exceptions.ThrowsSDE
   def getGeneratedFilePath(rootDir: String, pkg: String, filename: String): String = {
     val outDir = new java.io.File(rootDir + "/" + pkg.split('.').reduceLeft(_ + "/" + _))
     outDir.mkdirs()
-    val outPath = String.valueOf(outDir) + "/" + filename
+    val outPath = s"$outDir/$filename"
     outPath
   }
 

daffodil-propgen/src/main/scala/org/apache/daffodil/propGen/TunableGenerator.scala

@@ -292,7 +292,7 @@ class EnumListTunable(
       "Nil"
     } else {
       val defaultSeq =
-        trimmedDefault.split("\\s+").map(d => s"${listType}.${d.head.toUpper +: d.tail}")
+        trimmedDefault.split("\\s+").map(d => s"${listType}.${d.head.toUpper}${d.tail}")
       s"""Seq(${defaultSeq.mkString(", ")})"""
     }