feat: Makes error macros hygienic #18995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
Tpt
force-pushed
the
tpt/assert_hygiene
branch
from
0a7738c to
7295501
Compare
Tpt
force-pushed
the
tpt/assert_hygiene
branch
2 times, most recently
from
c07395b to
8f88a58
Compare
Use an absolute path for DatafusionError Allows removing a bunch of imports
Tpt
force-pushed
the
tpt/assert_hygiene
branch
from
8f88a58 to
960e906
Compare
2010YOUY01
approved these changes
Dec 1, 2025
Contributor
2010YOUY01
left a comment
2010YOUY01
left a comment
There was a problem hiding this comment.
Thank you, this is a very nice cleanup.
I'm re-triggering the CI by closing and re-opening the PR. Once passed, I'd like to merge it soon to avoid conflicts.
Contributor
Author
|
Thank you! |
ShashidharM0118
pushed a commit
to ShashidharM0118/datafusion
that referenced
this pull request
Dec 1, 2025
Use an absolute path for DatafusionError Allows removing a bunch of imports Co-authored-by: Yongting You <2010youy01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an absolute path for DatafusionError
Allows removing a bunch of imports