From 3f0e1a7a064c71d5c5555281fea811f3695d8c5a Mon Sep 17 00:00:00 2001
From: ShengHuang <huangshengtx@163.com>
Date: Sun, 18 Jan 2026 21:33:58 +0800
Subject: [PATCH] [Improvement-17855] A dependent node should't depend on the
 workflow it is in

---
 .../api/service/impl/WorkflowDefinitionServiceImpl.java       | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java
index f0c060562035..494afd90d011 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java
@@ -428,6 +428,10 @@ private List<WorkflowTaskLineage> generateWorkflowLineageList(List<TaskDefinitio
                     .parseObject(taskDefinitionLog.getTaskParams(), DependentParameters.class)
                     .getDependence().getDependTaskList()) {
                 for (DependentItem dependentItem : dependentTaskModel.getDependItemList()) {
+                    // A Dependent node cannot rely on itself workflow
+                    if (dependentItem.getDefinitionCode() == workflowDefinitionCode) {
+                        throw new ServiceException(Status.WORKFLOW_NODE_HAS_CYCLE);
+                    }
                     WorkflowTaskLineage workflowTaskLineage = new WorkflowTaskLineage();
                     workflowTaskLineage.setWorkflowDefinitionCode(workflowDefinitionCode);
                     workflowTaskLineage.setWorkflowDefinitionVersion(workflowDefinitionVersion);