diff --git a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java index 90280e802020..84c05b6736b3 100644 --- a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java +++ b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java @@ -71,6 +71,7 @@ private void paramsValidator(Map paramsMap) { String bodyParamsString = paramsMap.get(HttpAlertConstants.NAME_BODY_PARAMS); if (StringUtils.isNotBlank(bodyParamsString)) { + // bodyParams = JSONUtils.toMap(bodyParamsString); bodyParams = JSONUtils.parseObject(bodyParamsString, new TypeReference>() { }); if (bodyParams == null) { @@ -91,9 +92,9 @@ private void paramsValidator(Map paramsMap) { throw new IllegalArgumentException("contentType is not a valid value"); } - timeout = StringUtils.isNotBlank(paramsMap.get(HttpAlertConstants.NAME_TIMEOUT)) + timeout = (StringUtils.isNotBlank(paramsMap.get(HttpAlertConstants.NAME_TIMEOUT)) ? Integer.parseInt(paramsMap.get(HttpAlertConstants.NAME_TIMEOUT)) - : HttpAlertConstants.DEFAULT_TIMEOUT * 1000; + : HttpAlertConstants.DEFAULT_TIMEOUT) * 1000; } public AlertResult send(String msg) { @@ -218,9 +219,10 @@ private void setMsgInRequestBody(String msg) { } bodyParams.forEach((key, value) -> { - String valueOf = String.valueOf(value); - if (valueOf.contains(HttpAlertConstants.MSG_PARAMS)) { - bodyParams.put(key, valueOf.replace(HttpAlertConstants.MSG_PARAMS, msg)); + + String valueStr = String.valueOf(value); + if (valueStr.contains(HttpAlertConstants.MSG_PARAMS)) { + bodyParams.put(key, valueStr.replace(HttpAlertConstants.MSG_PARAMS, msg)); } }); }