Skip to content

[cleanup](iwyu) Remove unnecessary #include <vector> from 26 files#61544

Open
shuke987 wants to merge 1 commit intoapache:masterfrom
shuke987:iwyu-cleanup-vector
Open

[cleanup](iwyu) Remove unnecessary #include <vector> from 26 files#61544
shuke987 wants to merge 1 commit intoapache:masterfrom
shuke987:iwyu-cleanup-vector

Conversation

@shuke987
Copy link
Collaborator

Summary

  • Remove unnecessary #include <vector> from 26 BE source files
  • These files do not directly use std::vector
  • The header is transitively available through other included headers

Identified by include-what-you-use (IWYU 0.24 / Clang 20) analysis.

Test plan

  • Full BE incremental build passes with zero compilation errors
  • CI pipeline

🤖 Generated with Claude Code

IWYU analysis identified these files do not directly use std::vector.
The header is transitively available through other included headers.

Verified: full BE incremental build passes with zero compilation errors.
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 22, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zclllyybb
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 27216 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6f2f6b77edbdc345e5482f15a63f28cc8ebec849, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17649	4704	4355	4355
q2	q3	10646	794	530	530
q4	4675	361	259	259
q5	7569	1210	1031	1031
q6	176	175	147	147
q7	811	865	687	687
q8	9960	1528	1372	1372
q9	5712	4823	4441	4441
q10	6298	1930	1776	1776
q11	473	262	242	242
q12	732	581	508	508
q13	18053	2952	2165	2165
q14	223	233	214	214
q15	q16	741	755	671	671
q17	751	834	507	507
q18	5959	5472	5404	5404
q19	1110	993	623	623
q20	540	493	377	377
q21	4574	1994	1626	1626
q22	386	339	281	281
Total cold run time: 97038 ms
Total hot run time: 27216 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4847	4602	4710	4602
q2	q3	3969	4361	3812	3812
q4	886	1223	806	806
q5	4065	4471	4468	4468
q6	187	174	146	146
q7	1771	1638	1532	1532
q8	2512	2756	2577	2577
q9	7560	7343	7284	7284
q10	3825	4057	3630	3630
q11	514	451	425	425
q12	487	582	456	456
q13	2814	3196	2333	2333
q14	286	329	303	303
q15	q16	767	828	729	729
q17	1176	1386	1339	1339
q18	7086	6836	6608	6608
q19	940	964	963	963
q20	2138	2234	2107	2107
q21	3968	3485	3379	3379
q22	467	445	374	374
Total cold run time: 50265 ms
Total hot run time: 47873 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 168572 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6f2f6b77edbdc345e5482f15a63f28cc8ebec849, data reload: false

query5	4326	652	528	528
query6	349	236	215	215
query7	4224	499	267	267
query8	356	260	240	240
query9	8715	2774	2752	2752
query10	514	402	337	337
query11	6998	5083	4872	4872
query12	191	132	127	127
query13	1279	454	355	355
query14	5816	3773	3505	3505
query14_1	2841	2857	2839	2839
query15	211	199	182	182
query16	1000	523	477	477
query17	929	742	639	639
query18	2444	463	368	368
query19	219	216	192	192
query20	137	127	129	127
query21	218	134	113	113
query22	13237	14138	14562	14138
query23	16100	15713	15525	15525
query23_1	15639	15772	15615	15615
query24	7133	1627	1238	1238
query24_1	1241	1263	1216	1216
query25	630	469	408	408
query26	1242	257	153	153
query27	2794	485	300	300
query28	4470	1875	1846	1846
query29	845	557	474	474
query30	294	227	191	191
query31	991	947	871	871
query32	76	72	72	72
query33	520	327	285	285
query34	911	868	523	523
query35	623	686	597	597
query36	1076	1108	1003	1003
query37	134	95	84	84
query38	2955	2998	2889	2889
query39	851	861	812	812
query39_1	780	803	807	803
query40	240	153	136	136
query41	62	60	62	60
query42	262	256	254	254
query43	243	260	222	222
query44	
query45	199	190	179	179
query46	882	982	608	608
query47	2531	2150	2664	2150
query48	321	318	241	241
query49	655	465	383	383
query50	700	300	219	219
query51	4030	4038	4045	4038
query52	263	271	256	256
query53	290	339	293	293
query54	320	271	266	266
query55	88	86	85	85
query56	324	309	306	306
query57	1939	1725	1685	1685
query58	286	291	266	266
query59	2801	2953	2768	2768
query60	334	334	325	325
query61	161	157	160	157
query62	629	582	541	541
query63	311	289	278	278
query64	5084	1300	987	987
query65	
query66	1470	459	350	350
query67	24120	24183	24101	24101
query68	
query69	414	304	287	287
query70	957	874	887	874
query71	336	316	303	303
query72	2818	2641	2476	2476
query73	550	559	331	331
query74	9572	9542	9399	9399
query75	2828	2720	2447	2447
query76	2281	1043	698	698
query77	355	396	305	305
query78	10925	11022	10437	10437
query79	2768	784	582	582
query80	1731	609	547	547
query81	553	256	231	231
query82	997	144	123	123
query83	341	270	246	246
query84	300	117	96	96
query85	906	497	453	453
query86	423	310	327	310
query87	3114	3125	3024	3024
query88	3601	2655	2661	2655
query89	425	374	348	348
query90	2006	184	191	184
query91	171	168	138	138
query92	72	80	71	71
query93	1201	860	500	500
query94	638	296	299	296
query95	590	423	321	321
query96	653	529	229	229
query97	2435	2479	2401	2401
query98	244	222	214	214
query99	1010	986	904	904
Total cold run time: 251440 ms
Total hot run time: 168572 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants