-
Notifications
You must be signed in to change notification settings - Fork 690
[GEODE-10511] blocks-2.0.0 : Update LICENSE File with Correct Dependency Information #7961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Moved jakarta.servlet v6.0.0 and jakarta.transaction v2.0.1 from CDDL to EPL 2.0 section - These components use EPL 2.0 with GPL-2.0 + Classpath Exception, not CDDL 1.1
|
All checks have passed. We are ready to merge. Thank you for your support. |
|
Please let me know if you have any questions. Thank you for your help. |
sboorlagadda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to verify the correct version for istack-commons-runtime
| - jakarta.activation v1.2.1 | ||
| - jakarta.validation v2.0.2 | ||
| - jakarta.xml.bind v2.3.2 | ||
| - istack-commons-runtime v4.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we verify the version for istack-commons-runtime version discrepancy between LICENSE (v4.1.1) and DependencyConstraints.groovy (v4.0.1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, @sboorlagadda ! I've verified the discrepancy and updated DependencyConstraints.groovy to v4.1.1. The LICENSE file was correct - Gradle was already resolving to 4.1.1 due to the transitive dependency from jaxb-core/jaxb-runtime 4.0.2. This change eliminates the version conflict and aligns the declared version with what's actually resolved. Thank you so much for your help.
- Aligns declared version with actual resolved version - Eliminates version conflict resolution between 4.0.1 and 4.1.1 - Makes DependencyConstraints.groovy consistent with LICENSE file - jaxb-core/jaxb-runtime 4.0.2 transitively requires 4.1.1
sboorlagadda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thank you so much for your review, @sboorlagadda |
- Update geode-server-all dependency_classpath.txt - Update geode-assembly assembly_content.txt to remove 4.0.1 reference - Fixes integration test failures in both modules
Overview
This pull request comprehensively updates the Apache Geode LICENSE file to accurately reflect the current state of third-party dependencies. The changes include removing the CDDL dependency list, adding a new EPL 2.0 license section for Jakarta EE components, and updating dependency versions across multiple license sections to match the actual dependencies used in the project.
Related Issue
feature/GEODE-10511Problem Statement
The LICENSE file was outdated and contained several inaccuracies:
CDDL Dependencies Section: Listed legacy Java EE dependencies (javax.*) and old Jakarta versions that are no longer used in the project. The project has migrated to Jakarta EE 10 with different dependencies and licenses.
Missing EPL 2.0 Section: No dedicated section existed for Eclipse Public License 2.0 dependencies, even though multiple Jakarta EE components use this license.
Outdated Versions: Dependency versions listed across multiple license sections (BSD, EDL, MIT) did not match the actual versions used in the project's build configuration.
Incorrect License Attribution: The CDDL section incorrectly implied that current Jakarta EE components use CDDL, when they actually use EPL 2.0 with GPL-2.0 and Classpath Exception.
Changes Made
1. Removed Outdated CDDL Dependencies
Removed the following legacy Java EE dependencies from the CDDL section:
2. Added New EPL 2.0 License Section
Created a new section documenting components under EPL 2.0 with GPL-2.0 and Classpath Exception:
3. Updated EDL 1.0 Section
Updated the Eclipse Distribution License (EDL 1.0) section with current JAXB versions:
Removed:
Added:
4. Updated BSD 3-Clause Section
Updated component versions in the BSD 3-Clause section:
Added:
Updated:
5. Updated MIT License Section
Updated SLF4J version:
Verification
License Verification Process
All Jakarta EE component licenses were verified through:
Specific Verifications
Build Dependency Verification
Confirmed actual dependency versions used in the project:
build-tools/geode-dependency-management/src/main/groovy/org/apache/geode/gradle/plugins/DependencyConstraints.groovyImpact
Legal Compliance
Documentation
No Functional Changes
Testing
Validation Steps Completed
Expected Results
Files Changed
geode-assembly/src/main/dist/LICENSE(43 insertions, 16 deletions)Checklist
Additional Notes
Why Keep CDDL Section?
The CDDL 1.1 license section (including full license text) has been retained even though no current dependencies use it. This is intentional for:
Jakarta EE License Structure
Jakarta EE components use a dual-license structure:
This allows users to choose between EPL 2.0 or GPL-2.0 with Classpath Exception, providing maximum flexibility for different use cases.
Reviewer Notes
Key Review Points
DependencyConstraints.groovyReferences for Review
For all changes, please confirm:
develop)?gradlew buildrun cleanly?