[#6279] feat (gvfs-fuse): Add gvfs-fuse integration tests for big files and open-file flag test cases #6280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � .github/workflows/gvfs-fuse-build-test.yml � clients/filesystem-fuse/tests/bin/gvfs_fuse.sh
FANNG1
reviewed
Jan 23, 2025
| if self.buffer.len() > OpenDalFileSystem::WRITE_BUFFER_SIZE { | ||
| let mut new_buffer: Vec<u8> = | ||
| Vec::with_capacity(OpenDalFileSystem::WRITE_BUFFER_SIZE + 4096); | ||
| new_buffer.append(&mut self.buffer); |
There was a problem hiding this comment.
You didn't clear the buffer after writing to the underlying fs, is that expected?
There was a problem hiding this comment.
Yes, the self.buffer is cleared after the append operation.
There was a problem hiding this comment.
could you point out where did you clear the buffer?
FANNG1
reviewed
Jan 23, 2025
| Ok(data.len() as u32) | ||
| } | ||
|
|
||
| async fn close(&mut self) -> Result<()> { | ||
| if !self.buffer.is_empty() { | ||
| let mut new_buffer: Vec<u8> = vec![]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add gvfs-fuse integration tests for big files and open-file flag test cases
Why are the changes needed?
Fix: #6279
Does this PR introduce any user-facing change?
No
How was this patch tested?
IT