code review Oct 15.

Author: Dmitriy Fingerman

iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java

@@ -19,10 +19,13 @@
 
 package org.apache.iceberg.mr;
 
+import java.io.Closeable;
 import java.util.Map;
 import java.util.Optional;
 import java.util.Properties;
 import java.util.Set;
+
+import org.apache.commons.io.IOUtils;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.iceberg.CatalogUtil;
 import org.apache.iceberg.PartitionSpec;
@@ -111,16 +114,12 @@ private static Table loadTable(Configuration conf, String tableIdentifier, Strin
 
     if (catalog.isPresent()) {
       Preconditions.checkArgument(tableIdentifier != null, "Table identifier not set");
-
-      if (catalog.get() instanceof AutoCloseable) {
-        try (AutoCloseable ignored = (AutoCloseable) catalog.get()) {
-          return catalog.get().loadTable(TableIdentifier.parse(tableIdentifier));
-        } catch (Exception e) {
-          throw new RuntimeException("Failed to close catalog", e);
-        }
-      } else {
-        // fallback if not AutoCloseable
+      try {
         return catalog.get().loadTable(TableIdentifier.parse(tableIdentifier));
+      } finally {
+        if (catalog.get() instanceof Closeable closeable) {
+          IOUtils.closeQuietly(closeable);
+        }
       }
     }