Skip to content

Commit 4f0db29

Browse files
committed
Fix background context
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
1 parent f0b3bab commit 4f0db29

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

catalog/rest/rest_test.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1117,7 +1117,7 @@ func (r *RestCatalogSuite) TestDropTable404() {
11171117
}
11181118

11191119
func (r *RestCatalogSuite) TestRegisterTable200() {
1120-
r.mux.HandleFunc("/v1/namespaces/fokko/tables/table", func(w http.ResponseWriter, req *http.Request) {
1120+
r.mux.HandleFunc("/v1/namespaces/fokko/tables/fokko2", func(w http.ResponseWriter, req *http.Request) {
11211121
r.Require().Equal(http.MethodPost, req.Method)
11221122

11231123
for k, v := range TestHeaders {
@@ -1129,7 +1129,7 @@ func (r *RestCatalogSuite) TestRegisterTable200() {
11291129
MetadataLoc string `json:"metadata-location"`
11301130
}
11311131
r.NoError(json.NewDecoder(req.Body).Decode(&payload))
1132-
r.Equal("table", payload.Name)
1132+
r.Equal("fokko2", payload.Name)
11331133
r.Equal("s3://warehouse/database/table/metadata/00001-5f2f8166-244c-4eae-ac36-384ecdec81fc.gz.metadata.json", payload.MetadataLoc)
11341134

11351135
w.WriteHeader(http.StatusOK)
@@ -1251,7 +1251,7 @@ func (r *RestCatalogSuite) TestRegisterTable200() {
12511251
}`))
12521252
})
12531253

1254-
cat, err := rest.NewCatalog("rest", r.srv.URL, rest.WithOAuthToken(TestToken))
1254+
cat, err := rest.NewCatalog(context.Background(), "rest", r.srv.URL, rest.WithOAuthToken(TestToken))
12551255
r.Require().NoError(err)
12561256

12571257
tbl, err := cat.RegisterTable(context.Background(), catalog.ToIdentifier("fokko", "fokko2"), "s3://warehouse/database/table/metadata/00001-5f2f8166-244c-4eae-ac36-384ecdec81fc.gz.metadata.json")
@@ -1262,7 +1262,6 @@ func (r *RestCatalogSuite) TestRegisterTable200() {
12621262
r.EqualValues(1, tbl.Metadata().Version())
12631263
r.Equal("d55d9dda-6561-423a-8bfc-787980ce421f", tbl.Metadata().TableUUID().String())
12641264
r.Equal("bryan", tbl.Metadata().Properties()["owner"])
1265-
// TODO Add more asserting on the schema
12661265
}
12671266

12681267
func (r *RestCatalogSuite) TestRegisterTable404() {
@@ -1290,7 +1289,7 @@ func (r *RestCatalogSuite) TestRegisterTable404() {
12901289
}
12911290
}`))
12921291
})
1293-
cat, err := rest.NewCatalog("rest", r.srv.URL, rest.WithOAuthToken(TestToken))
1292+
cat, err := rest.NewCatalog(context.Background(), "rest", r.srv.URL, rest.WithOAuthToken(TestToken))
12941293
r.Require().NoError(err)
12951294

12961295
_, err = cat.RegisterTable(context.Background(), catalog.ToIdentifier("nonexistent", "fokko2"), "s3://warehouse/database/table/metadata/00001-5f2f8166-244c-4eae-ac36-384ecdec81fc.gz.metadata.json")
@@ -1323,7 +1322,7 @@ func (r *RestCatalogSuite) TestRegisterTable409() {
13231322
}
13241323
}`))
13251324
})
1326-
cat, err := rest.NewCatalog("rest", r.srv.URL, rest.WithOAuthToken(TestToken))
1325+
cat, err := rest.NewCatalog(context.Background(), "rest", r.srv.URL, rest.WithOAuthToken(TestToken))
13271326
r.Require().NoError(err)
13281327

13291328
_, err = cat.RegisterTable(context.Background(), catalog.ToIdentifier("fokko", "alreadyexist"), "s3://warehouse/database/table/metadata/00001-5f2f8166-244c-4eae-ac36-384ecdec81fc.gz.metadata.json")

0 commit comments

Comments
 (0)