From 41e0f0f6b95b6a6c7d87d45c1e6b844a84b79187 Mon Sep 17 00:00:00 2001 From: Kevin Liu Date: Thu, 12 Sep 2024 22:38:49 -0700 Subject: [PATCH 1/5] run on matrix --- .github/workflows/python-integration.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/python-integration.yml b/.github/workflows/python-integration.yml index 6aeae0fc9e..79747cf466 100644 --- a/.github/workflows/python-integration.yml +++ b/.github/workflows/python-integration.yml @@ -31,7 +31,11 @@ concurrency: jobs: integration-test: - runs-on: ubuntu-20.04 + name: Run integration test on ${{ matrix.os }} + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ ubuntu-22.04, windows-2022, macos-12, macos-13, macos-14 ] steps: - uses: actions/checkout@v4 From 8dabcf252c2f07e52dd035504a2aa50330bf1082 Mon Sep 17 00:00:00 2001 From: Kevin Liu Date: Thu, 12 Sep 2024 22:44:43 -0700 Subject: [PATCH 2/5] install docker --- .github/workflows/python-integration.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/python-integration.yml b/.github/workflows/python-integration.yml index 79747cf466..a53d87435a 100644 --- a/.github/workflows/python-integration.yml +++ b/.github/workflows/python-integration.yml @@ -41,6 +41,8 @@ jobs: - uses: actions/checkout@v4 with: fetch-depth: 2 + - name: Setup Docker on macOS + uses: douglascamata/setup-docker-macos-action@v1-alpha - name: Install run: make install - name: Run integration tests From af2b89c76c603feaf941a6ec4f47ba5a7ecf8ee3 Mon Sep 17 00:00:00 2001 From: Kevin Liu Date: Thu, 12 Sep 2024 22:59:03 -0700 Subject: [PATCH 3/5] only for mac --- .github/workflows/python-integration.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/python-integration.yml b/.github/workflows/python-integration.yml index a53d87435a..dd7800ac5b 100644 --- a/.github/workflows/python-integration.yml +++ b/.github/workflows/python-integration.yml @@ -42,6 +42,7 @@ jobs: with: fetch-depth: 2 - name: Setup Docker on macOS + if: startsWith(matrix.os, 'macos') uses: douglascamata/setup-docker-macos-action@v1-alpha - name: Install run: make install From fc4761e9669354a43e5ca38d4d2df24fe9cdee2d Mon Sep 17 00:00:00 2001 From: Kevin Liu Date: Thu, 12 Sep 2024 23:03:45 -0700 Subject: [PATCH 4/5] does not support macos-14 --- .github/workflows/python-integration.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-integration.yml b/.github/workflows/python-integration.yml index dd7800ac5b..a31ab5fc29 100644 --- a/.github/workflows/python-integration.yml +++ b/.github/workflows/python-integration.yml @@ -35,7 +35,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - os: [ ubuntu-22.04, windows-2022, macos-12, macos-13, macos-14 ] + os: [ ubuntu-22.04, windows-2022, macos-12, macos-13 ] steps: - uses: actions/checkout@v4 From 919b7ef9b5ae608d190bebe1e31d170b3267edfa Mon Sep 17 00:00:00 2001 From: Kevin Liu Date: Thu, 12 Sep 2024 23:06:40 -0700 Subject: [PATCH 5/5] no windows-2022 either --- .github/workflows/python-integration.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-integration.yml b/.github/workflows/python-integration.yml index a31ab5fc29..9362b16edb 100644 --- a/.github/workflows/python-integration.yml +++ b/.github/workflows/python-integration.yml @@ -35,7 +35,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - os: [ ubuntu-22.04, windows-2022, macos-12, macos-13 ] + os: [ ubuntu-22.04, macos-12, macos-13 ] steps: - uses: actions/checkout@v4