diff --git a/src/replica/replica_stub.cpp b/src/replica/replica_stub.cpp index 7a51ee4cac..2e4eec66e3 100644 --- a/src/replica/replica_stub.cpp +++ b/src/replica/replica_stub.cpp @@ -276,11 +276,6 @@ DSN_DEFINE_bool(replication, mem_release_enabled, true, "whether to enable periodic memory release"); -DSN_DEFINE_bool( - replication, - gc_disabled, - false, - "Whether to disable replica statistics. The name contains 'gc' is for legacy reason"); DSN_DEFINE_bool(replication, disk_stat_disabled, false, "whether to disable disk stat"); DSN_DEFINE_bool( replication, @@ -341,6 +336,8 @@ bool check_mem_release_max_reserved_mem_percentage(int32_t value) DSN_DEFINE_validator(mem_release_max_reserved_mem_percentage, &check_mem_release_max_reserved_mem_percentage); +DSN_DEFINE_bool(replication, replicas_stat_disabled, false, "whether to disable replicas stat"); + DSN_DEFINE_uint32(replication, replicas_stat_interval_ms, 30000, @@ -630,9 +627,9 @@ void replica_stub::initialize(const replication_options &opts, bool clear /* = f } // replicas stat - if (!FLAGS_gc_disabled) { + if (!FLAGS_replicas_stat_disabled) { _replicas_stat_timer_task = tasking::enqueue_timer( - LPC_GARBAGE_COLLECT_LOGS_AND_REPLICAS, + LPC_REPLICAS_STAT, &_tracker, [this] { on_replicas_stat(); }, std::chrono::milliseconds(FLAGS_replicas_stat_interval_ms), diff --git a/src/replica/replica_stub.h b/src/replica/replica_stub.h index 328e975024..d3b8600764 100644 --- a/src/replica/replica_stub.h +++ b/src/replica/replica_stub.h @@ -184,7 +184,6 @@ class replica_stub : public serverlet, public ref_counter // void on_meta_server_connected(); void on_meta_server_disconnected(); - void on_replicas_stat(); void on_disk_stat(); // @@ -385,6 +384,8 @@ class replica_stub : public serverlet, public ref_counter }; using replica_stat_info_by_gpid = std::unordered_map; + void on_replicas_stat(); + void response_client(gpid id, bool is_read, dsn::message_ex *request,