Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The wait_manual_compact() function in the pegasus_manual_compact.sh script cannot correctly detect the execution progress of the manual compact #2190

Open
limowang opened this issue Feb 6, 2025 · 1 comment
Labels
type/bug This issue reports a bug.

Comments

@limowang
Copy link
Collaborator

limowang commented Feb 6, 2025

Bug Report

  1. What did you do?
    When using the command sh pegasus_manual_compact.sh -c {meta_server_list} -a {table_name} --bottommost_level_compaction force, the wait_manual_compact() function keeps writing the log [35s] 0 finished, 8 not finished (0 in queue, 0 in running), estimate remaining unknown seconds. table [**] manual compaction is running now. even though the manual compaction task has already finished. This causes the wait_manual_compact() function's output to be used to determine the task progress when encapsulating the manual_compact tool, leading to a timeout failure.

  2. What did you expect to see?
    The function wait_manual_compact() can correctly parse the output of the shell command remote_command -t replica-server replica.query-compact ${app_id}.

  3. What did you see instead?
    Cannot correctly parse.

@limowang
Copy link
Collaborator Author

The shell command remote_command -t replica-server replica.query-compact ${app_id} outputs in the following format in the latest version:
CALL [replica-server] [10.1.132.34:8171] succeed:
8 processed, 0 not found
4.0@10.1.132.34:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}
4.1@10.1.132.34:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}
4.2@10.1.132.34:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}
4.3@10.1.132.34:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}
4.4@10.1.132.34:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}
4.5@10.1.132.34:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}
4.6@10.1.132.34:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}
4.7@10.1.132.34:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}

Below is the output example from the previous version:
CALL [replica-server] [10.1.132.36:8171] succeed: 8 processed, 0 not found
4.0@10.1.132.36:8171@P : last finish at [-]
4.1@10.1.132.36:8171@P : last finish at [-]
4.2@10.1.132.36:8171@P : last finish at [-]
4.3@10.1.132.36:8171@P : last finish at [-]
4.4@10.1.132.36:8171@P : last finish at [-]
4.5@10.1.132.36:8171@P : last finish at [-]
4.6@10.1.132.36:8171@P : last finish at [-]
4.7@10.1.132.36:8171@P : last finish at [-]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug This issue reports a bug.
Projects
None yet
Development

No branches or pull requests

1 participant