Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new metric API #756

Closed
zhangyifan27 opened this issue Jun 7, 2021 · 3 comments
Closed

Introduce new metric API #756

zhangyifan27 opened this issue Jun 7, 2021 · 3 comments
Labels
type/enhancement Indicates new feature requests type/incompatible Changes that introduced incompatibility to Pegasus.

Comments

@zhangyifan27
Copy link
Contributor

Feature Request

RFC: https://github.com/apache/incubator-pegasus/blob/master/rfcs/2020-08-27-metric-api.md

An in progress implement: XiaoMi/rdsn#605
@zhangyifan27 zhangyifan27 added the type/enhancement Indicates new feature requests label Jun 7, 2021
@hycdong hycdong added the type/incompatible Changes that introduced incompatibility to Pegasus. label Dec 21, 2021
@hycdong
Copy link
Contributor

hycdong commented Dec 21, 2021

It is welcomed that @empiredan would like to contribute this feature~
However, new metric API may adds compatible problems, including collector upgrade, such monitor and other tools. The commits should not be merged into master immediately but https://github.com/XiaoMi/rdsn/tree/prometheus-dev

@empiredan empiredan mentioned this issue Jan 20, 2022
Closed
@empiredan
Copy link
Contributor

empiredan commented Mar 4, 2022 •
edited
Loading

The issue that tracks the implementation and the schedule of the framework is #922.

acelyc111 pushed a commit that referenced this issue Jun 23, 2022
@levy5307
fix: delete unused flags rocksdb_target_file_size_base and `rocksdb…
cf8a420 
…_write_buffer_size` (#756)
@acelyc111
Copy link
Member

duplicated, will be tracked by #922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Indicates new feature requests type/incompatible Changes that introduced incompatibility to Pegasus.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@empiredan @acelyc111 @hycdong @zhangyifan27