This repository was archived by the owner on Feb 8, 2019. It is now read-only.
Updated builds to use proto3 libraries. #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vega113
approved these changes
May 9, 2017
| // without any other information (e.g. without reading its imports). | ||
|
|
||
|
|
||
| syntax = "proto2"; |
Contributor
There was a problem hiding this comment.
looks like we have two "syntax" fields
| option go_package = "github.com/golang/protobuf/protoc-gen-go/descriptor;descriptor"; | ||
| option java_package = "com.google.protobuf"; | ||
| option java_outer_classname = "DescriptorProtos"; | ||
| option csharp_namespace = "Google.Protobuf.Reflection"; |
Contributor
There was a problem hiding this comment.
Do we need csharp namespace?
Contributor
Author
There was a problem hiding this comment.
I do not feel comfortable editing this as its the original file from google which we have listed in the license.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to move forward with using proto3 buffers with new client while keeping old client functional.