FusekiServerRunner does not load custom modules.

[Aklakan]

Version

5.4.0-SNAPSHOT

What happened?

I am trying to start a jena-fuseki-server bundle with the spatial indexer plugin added as a custom mod (org.apache.jena.fuseki.main.sys.FusekiAutoModule). However, it is not getting loaded (neither when added as a dependency nor as a separate jar file on the classpath). The jena-geosparql dependency initializes properly and prints out its log messages (uses org.apache.jena.sys.JenaSubsystemLifecycle).

I also tried starting as java -jar jena-fuseki-server-5.4.0-SNAPSHOT.jar --modules=true and launching FusekiServerRunner --modules=true directly from eclipse.

Recently, there has been #3001 - and if I am not mistaken, it's not fully fixed:

In FusekiServerRunner.java a set of default modules is registered:

jena/jena-fuseki2/jena-fuseki-main/src/main/java/org/apache/jena/fuseki/mod/FusekiServerRunner.java

Lines 81 to 90 in a50f0fe

	FusekiModules serverModules = serverModules();
	// Adjust the default settings of ServerArgs
	FusekiServerArgsCustomiser initializeServerArgs = new FusekiServerArgsCustomiser() {
	@Override
	public void serverArgsModify(CmdGeneral fusekiCmd, ServerArgs serverArgs) {
	serverArgs.allowEmpty = true;
	serverArgs.fusekiModules = serverModules;
	}
	};

In FusekiMain.java, a check is made for whether modules have already been initialized. It detects the default modules and skips loading of custom modules.

jena/jena-fuseki2/jena-fuseki-main/src/main/java/org/apache/jena/fuseki/main/cmds/FusekiMain.java

Lines 583 to 589 in a50f0fe

	// Allows for external setting of serverArgs.fusekiModules
	if ( serverArgs.fusekiModules == null ) {
	// Get modules from system-wide setup.
	boolean withModules = hasValueOfTrue(argEnableModules);
	if ( withModules )
	serverArgs.fusekiModules = FusekiModules.getSystemModules();
	}

I don't know how the logic is expected to work. Perhaps module loading needs to be split for fusekiModules (always present regardless of --modules setting) and customFusekiModules?

Relevant output and stacktrace

Are you interested in making a pull request?

Maybe