Skip to content

KAFKA-19930: Adding process handler null check for global threads #21016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-19930: Adding process handler null check for global threads #21016

wants to merge 2 commits into from
+36 −3

Conversation

@iit2009060
Copy link
Contributor

@iit2009060 iit2009060 commented Nov 28, 2025 •
edited by github-actions bot
Loading

  1. Added process handler null check for global threads.
  2. Added unit test to verify it.
  3. Updated the documentation.

Reviewers: Matthias J. Sax matthias@confluent.io

@github-actions github-actions bot added triage PRs from the community streams small Small PRs labels Nov 28, 2025
@iit2009060
Copy link
Contributor Author

iit2009060 commented Nov 28, 2025

@mjsax Can you please review it.

@mjsax mjsax added ci-approved and removed triage PRs from the community labels Nov 28, 2025
mjsax
mjsax approved these changes Nov 28, 2025
View reviewed changes
Copy link
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@mjsax mjsax changed the title KAFKA-19930 Adding process handler null check for global threads KAFKA-19930: Adding process handler null check for global threads Nov 28, 2025
@mjsax
Copy link
Member

mjsax commented Nov 28, 2025

Should we also update StreamsConfig#PROCESSING_EXCEPTION_HANDLER_CLASS_DOC and maybe also StreamsConfig#ERRORS_DEAD_LETTER_QUEUE_TOPIC_NAME_DOC ?

@iit2009060
Copy link
Contributor Author

iit2009060 commented Nov 29, 2025

Should we also update StreamsConfig#PROCESSING_EXCEPTION_HANDLER_CLASS_DOC and maybe also StreamsConfig#ERRORS_DEAD_LETTER_QUEUE_TOPIC_NAME_DOC ?

Updated , @mjsax Please review it .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjsax mjsax mjsax approved these changes

Assignees

No one assigned

Labels

ci-approved small Small PRs streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iit2009060 @mjsax