hw/scripts/nrfutil: make traits optional and improve device selection #3534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanc
reviewed
Nov 18, 2025
hw/scripts/nrfutil.sh
Outdated
| fi | ||
|
|
||
| ret=0 | ||
| if [ -z ${NRFUTIL_TRAITS} ] ; then |
Contributor
There was a problem hiding this comment.
we should also double check if traits are used correctly
from what I understand traits are used only for device matching, not for selecting type of update to be performed
wiktorkwiatkowski
force-pushed
the
nrfutil_sn
branch
from
9c701bf to
539bffd
Compare
wiktorkwiatkowski
changed the title
Traits are no longer by default. They are now optional and only used when the user explicitly wants to flash multiple boards at once. DFU mode is controlled through NRFUTIL_DFU_MODE, and NRFUTIL_DFU_SN can be used to select a specific DFU device when several are connected.
wiktorkwiatkowski
force-pushed
the
nrfutil_sn
branch
from
539bffd to
e18fa71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traits are no longer by default. They are now optional and only used when the user explicitly wants to flash multiple boards at once. DFU mode is controlled through NRFUTIL_DFU_MODE, and NRFUTIL_DFU_SN can be used to select a specific DFU device when several are connected.