Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support maximum compression ratio in setSpeed #1715

Open
deshanxiao opened this issue Dec 29, 2023 · 2 comments
Open

Support maximum compression ratio in setSpeed #1715

deshanxiao opened this issue Dec 29, 2023 · 2 comments

Comments

@deshanxiao
Copy link
Contributor

deshanxiao commented Dec 29, 2023

Now we only support FAST, DEFAULT and FASTEST. We can support the maximum compression rate like BEST_COMPRESSION.

@deshanxiao deshanxiao changed the title Supports maximum compression ratio in setSpeed Support maximum compression ratio in setSpeed Dec 29, 2023
@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jan 4, 2024

Could you elaborate more about your idea? @deshanxiao ?

  • Do you want to support it only for a specific codec like brotli or for all codec?
  • Is there any reference in Parquet?

@deshanxiao
Copy link
Contributor Author

deshanxiao commented Jan 4, 2024

Could you elaborate more about your idea? @deshanxiao ?

  • Do you want to support it only for a specific codec like brotli or for all codec?
  • Is there any reference in Parquet?
  1. Actually I want to support it for all codec.
  2. Yes, Parquet is more flexible and can directly set the value of the compression level. See Parquet CodecFactory

Alternatively, we can consider adding a new method in CompressionOption to directly set the compression level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants