Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParquetMetadataConverter should never log at level WARN #3025

Open
wallacms opened this issue Oct 7, 2024 · 0 comments
Open

ParquetMetadataConverter should never log at level WARN #3025

wallacms opened this issue Oct 7, 2024 · 0 comments

Comments

@wallacms
Copy link

wallacms commented Oct 7, 2024

Describe the bug, including details regarding any error messages, version, and platform.

When ParquetMetadataConverter encounters a mismatch between logical and converted type, it logs a message at level WARN.

This behavior does not make sense because one of two things must be true:

  1. This is an issue that can affect normal operation and the application needs to (potentially) respond to it
  2. This is not a concern for the calling application and it won't impact normal operation

If item 1 is true, then an exception should be thrown and the application choose to respond or not (possibly by logging). If item item 2 is true, then the log message should either be omitted entirely or be logged at level DEBUG (INFO level would still be too spammy)

I would be happy to submit a patch if there is consensus about which approach to take. Perhaps there should be a flag to control whether the exception should be thrown to avoid breaking existing code.

Component(s)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant