Kubernetes Service Discovery Custom Settings #313
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can create different settings based on config path - Added "Settings" object to KubernetesApiServiceDiscovery constructor so that users are able to provide their different settings for discovery
Roiocam
reviewed
Sep 25, 2024
discovery-kubernetes-api/src/main/scala/org/apache/pekko/discovery/kubernetes/Settings.scala
Outdated
Show resolved
Hide resolved
pjfanning
reviewed
Sep 25, 2024
...api/src/main/scala/org/apache/pekko/discovery/kubernetes/KubernetesApiServiceDiscovery.scala
Outdated
Show resolved
Hide resolved
pjfanning
reviewed
Sep 25, 2024
...api/src/main/scala/org/apache/pekko/discovery/kubernetes/KubernetesApiServiceDiscovery.scala
Outdated
Show resolved
Hide resolved
pjfanning
reviewed
Sep 25, 2024
discovery-kubernetes-api/src/main/scala/org/apache/pekko/discovery/kubernetes/Settings.scala
Outdated
Show resolved
Hide resolved
pjfanning
reviewed
Sep 25, 2024
...api/src/main/scala/org/apache/pekko/discovery/kubernetes/KubernetesApiServiceDiscovery.scala
Show resolved
Hide resolved
|
I'm ok with merging this if other reviewers are happy to proceed. |
|
(failure is #216 again) |
raboof
approved these changes
Sep 26, 2024
|
@Roiocam did you want to do a re-review or are we OK to (Squash and) merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #311
Added configNamespace in Kubernetes settings object, so that users can create different settings based on config path
Added "Settings" object to KubernetesApiServiceDiscovery constructor so that users are able to provide their different settings for discovery