Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building from source + sbt-docker-compose. #88

Closed
wants to merge 1 commit into from
Closed

Building from source + sbt-docker-compose. #88

wants to merge 1 commit into from

Conversation

samueleresca
Copy link
Member

@samueleresca samueleresca commented Nov 12, 2023 •
edited
Loading

  • Updating Buliding from source section.
  • Adding sbt-docker-compose to run docker-compose as part of sbt tooling

Fixes #87

pjfanning
pjfanning requested changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced that we need the sbt plugin.

All you need to run the tests is to have Docker machine running on your laptop. "com.dimafeng" %% "testcontainers-scala-scalatest" does the rest.

@samueleresca
Copy link
Member Author

I'm not convinced that we need the sbt plugin.

All you need to run the tests is to have Docker machine running on your laptop. "com.dimafeng" %% "testcontainers-scala-scalatest" does the rest.

@pjfanning I hadn't noticed it was using testcontainers. I'm proceeding by closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjfanning pjfanning pjfanning requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add docs about building from source
2 participants
@samueleresca @pjfanning