issue with tick params in wrong order #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
requested review from
raboof,
He-Pin,
mdedetrich,
samueleresca and
Roiocam
|
I'll keep an eye on the tests to see if the H2 test issues happen regularly |
pjfanning
added a commit
to pjfanning/incubator-pekko-persistence-jdbc
that referenced
this pull request
Apr 25, 2024
Roiocam
pushed a commit
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interval is the 2nd param and needs to be greater than 0.
The 1st param is the delay and 0 seconds is a valid value for the delay.
Causing test failures seen in #181
I think we should backport this to the 1.0.x branch