Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test with java 21 #207

Merged
merged 1 commit into from
Jul 1, 2024
Merged

test with java 21 #207

merged 1 commit into from
Jul 1, 2024

Conversation

pjfanning
Copy link
Contributor

No description provided.

raboof
raboof approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if 21 works, should we drop 11 and 17?

@pjfanning
Copy link
Contributor Author

if 21 works, should we drop 11 and 17?

We test with all the Java LTS releases in our other repos. I'm just trying to stay consistent.
In practice, we've hit very few issues building with different Java versions. Unfortunately, people do tend to ask us if we don't document that we test with their favourite JDK version.

Roiocam
Roiocam approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@Roiocam Roiocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great complement

@pjfanning pjfanning merged commit 7fea6bd into apache:main Jul 1, 2024
26 checks passed
@pjfanning pjfanning deleted the java-21 branch July 1, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

@Roiocam Roiocam Roiocam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjfanning @raboof @Roiocam