[Bug][Producer]Inaccurate transaction endSendOrAckOp for chunked message

[gunli]

Expected behavior

When chunking, call transaction.endSendOrAckOp() only for the last chunked reqeust???

Actual behavior

I am NOT sure if it is a bug.

In internalSend(), when chunking, we share the transaction between all the chunked request:

nsr := &sendRequest{
	ctx:              request.ctx,
	msg:              request.msg,
	callback:         request.callback,
	callbackOnce:     request.callbackOnce,
	publishTime:      request.publishTime,
	blockCh:          request.blockCh,
	closeBlockChOnce: request.closeBlockChOnce,
	totalChunks:      totalChunks,
	chunkID:          chunkID,
	uuid:             uuid,
	chunkRecorder:    cr,
	transaction:      request.transaction,
}

In ReceivedSendReceipt(), we call transaction.endSendOrAckOp() for every request without checking if it is the last chunked one

if sr.transaction != nil {
	sr.transaction.endSendOrAckOp(nil)
}

In failTimeoutMessages(), we call transaction.endSendOrAckOp() for every request without checking if it is the last chunked one

if sr.transaction != nil {
	sr.transaction.endSendOrAckOp(nil) // And I think it should be errSendTimeout here
}

Steps to reproduce

Code review.

System configuration

Pulsar version: master

@RobertIndie @Gleiphir2769

[RobertIndie]

Could you take a look at this? @liangyepianzhou

[liangyepianzhou]

@gunli You are right. Thanks for you point it out. I have pushed a PR to fix it.

[liangyepianzhou]

In failTimeoutMessages(), we call transaction.endSendOrAckOp() for every request without checking if it is the last >chunked one

if sr.transaction != nil {
  sr.transaction.endSendOrAckOp(nil) // And I think it should be errSendTimeout here
}

The errSendTimeout already was passed into the callback just before sr.transaction.endSendOrAckOp(nil).

if sr.callback != nil {
	sr.callbackOnce.Do(func() {
		sr.callback(nil, sr.msg, errSendTimeout)
	})
}
if (sr.totalChunks <= 1 || sr.chunkID == sr.totalChunks-1) && sr.transaction != nil {
	sr.transaction.endSendOrAckOp(nil)
}