Enable accessing Message in TableView #1174
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1176
Motivation
The current TableView implementation only stores the payload encoded to the
SchemaValueType
of each incoming message. There are many use cases where accessing the full metadata of thepulsar.Message
type is needed, so this PR refactors the map storage of messages to be thepulsar.Message
received from the consumer rather than the payload.All the existing APIs are maintained by performing the payload encoding when the methods (e.g.
Get
) are called.Two new public methods,
Message
andMessages
, are introduced to access thepulsar.Message
for each key so that accompanying metadata for a payload can be easily retrieved.Modifications
handleMessage
method now stores thepulsar.Message
type and only encodes to theSchemaValueType
for listeners.Get
andEntries
use theSchemaValueType
when called to convert frompulsar.Message
to the payloadMessage
andMessages
, introduced to get full metadata.Verifying this change
This change added tests, and is covered by existing tests, and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesMessage
andMessages
methods on TableView interface. Existing API not impactedDocumentation