Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 797]Filter tableview message for empty key and add example for tableview #798

Closed

Conversation

liangyuanpeng
Copy link
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #797

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

  • Add example for tableview
  • Filter tableview message for empty key

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Contributor

@pgier pgier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -242,17 +242,20 @@ func (tv *TableViewImpl) Close() {
}

func (tv *TableViewImpl) handleMessage(msg Message) {
tv.dataMu.Lock()
defer tv.dataMu.Unlock()
if msg.Key() != "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion to just return if the key is empty instead of nesting in the if.

Suggested change
if msg.Key() != "" {
if msg.Key() == "" {
return
}

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liangyuanpeng The change looks good, can you also expand the unit test to verify the key is delete from the table view?

@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Sep 7, 2022

@merlimat @pgier Resolved review conment and add test, PTAL, Thanks.

@liangyuanpeng
Copy link
Contributor Author

Closed by not review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example for tableview
3 participants