-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 797]Filter tableview message for empty key and add example for tableview #798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pulsar/table_view_impl.go
Outdated
@@ -242,17 +242,20 @@ func (tv *TableViewImpl) Close() { | |||
} | |||
|
|||
func (tv *TableViewImpl) handleMessage(msg Message) { | |||
tv.dataMu.Lock() | |||
defer tv.dataMu.Unlock() | |||
if msg.Key() != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion to just return if the key is empty instead of nesting in the if.
if msg.Key() != "" { | |
if msg.Key() == "" { | |
return | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liangyuanpeng The change looks good, can you also expand the unit test to verify the key is delete from the table view?
Closed by not review. |
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #797
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation