Skip to content

Commit e036664

Browse files
authored
Fix GHA workflow syntax (#511)
Signed-off-by: tison <wander4096@gmail.com>
1 parent 482ec65 commit e036664

File tree

4 files changed

+35
-42
lines changed

4 files changed

+35
-42
lines changed

.github/workflows/gradle.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,18 @@ name: Java CI
2020
on:
2121
push:
2222
branches: [master]
23-
pull_request: [master]
23+
pull_request:
24+
branches: [master]
2425

2526
jobs:
2627
build:
2728
runs-on: ubuntu-latest
2829
steps:
2930
- uses: actions/checkout@v3
30-
- name: Set up JDK 1.8
31+
- name: Set up JDK 8
3132
uses: actions/setup-java@v3
3233
with:
33-
java-version: 1.8
34+
java-version: 8
35+
distribution: temurin
3436
- name: Build with Gradle
3537
run: ./gradlew build

CONTRIBUTING.md

Lines changed: 28 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -10,40 +10,35 @@ Before committing code changes to Apache Pulsar Manager, you need to install req
1010

1111
If you have not installed Java and Node, follow the instructions below.
1212

13-
Dependency | Installation guide
14-
|---|---
15-
Java 8 | https://openjdk.java.net/install/
16-
Node 10.15 | https://nodejs.org/en/
13+
| Dependency | Installation guide |
14+
| ---------- | --------------------------------- |
15+
| Java 8 | https://openjdk.java.net/install/ |
16+
| Node 10.15 | https://nodejs.org/en/ |
1717

1818
### Fork pulsar-manager repository
1919

2020
Fork the [pulsar-manager](https://github.com/apache/pulsar-manager) repository to your GitHub repository.
2121

22-
### Install pulsar-manager dependency
22+
### Install pulsar-manager dependency
2323

2424
1. Clone pulsar-manager code to your machine.
25-
25+
2626
```bash
27-
$ git clone git@github.com:[your-github-id]/pulsar-manager.git
27+
git clone git@github.com:[your-github-id]/pulsar-manager.git
2828
```
2929

3030
2. Install pulsar-manger dependencies.
31-
32-
```bash
33-
$ cd pulsar-manager
34-
35-
$ ./gradlew build -x test
3631

37-
$ cd front-end
38-
39-
$ npm install --save
32+
```bash
33+
cd pulsar-manager
34+
./gradlew build -x test
4035
```
4136

42-
## Configure IDE
37+
## Configure IDE
4338

4439
Apache Pulsar Manager uses [lombok](https://projectlombok.org/), so set up your IDE with the required plugins.
4540

46-
### Configure Intellij
41+
### Configure Intellij
4742

4843
To configure annotation processing in IntelliJ, follow the steps below.
4944

@@ -60,35 +55,32 @@ Follow the instructions [here](https://howtodoinjava.com/automation/lombok-eclip
6055
## Contribution workflow
6156

6257
1. Add a remote repository.
63-
58+
6459
```bash
65-
$ git remote add apache git@github.com:apache/pulsar-manager.git
60+
git remote add apache git@github.com:apache/pulsar-manager.git
6661
```
6762

6863
2. Sync you local repository with the remote repository.
6964

7065
```bash
71-
$ git checkout master
72-
$ git pull apache master
66+
git checkout master
67+
git pull apache master
7368
```
7469

7570
3. Create your PR and commit code changes.
7671

7772
```bash
78-
$ git checkout -b your_branch
79-
80-
$ git add [your change files]
81-
82-
$ git commit -m "commit messages"
83-
84-
$ git push origin your_branch
73+
git checkout -b your_branch
74+
git add [your change files]
75+
git commit -m "commit messages"
76+
git push origin your_branch
8577
```
8678

87-
> #### Note
88-
>
89-
> Apache Pulsar Manager uses the open-source protocol of Apache License 2.0.
79+
> **Note**
80+
>
81+
> Pulsar Manager is released under Apache License 2.0.
9082
>
91-
> If you commit code changes with new files, run the following command to add the license at the beginning of each file.
83+
> If you commit new files, run the following command to add the license header for each file:
9284
>
9385
> ```bash
9486
> ./gradlew licenseFormat
@@ -100,8 +92,8 @@ Follow the code styles below to keep code consistent and easy to maintain.
10092

10193
Make sure your code looks plain and simple.
10294

103-
Language | Code style guide
104-
|---|---
105-
Java | https://google.github.io/styleguide/javaguide.html
106-
Vue | https://vuejs.org/v2/style-guide/
95+
| Language | Code style guide |
96+
| -------- | -------------------------------------------------- |
97+
| Java | https://google.github.io/styleguide/javaguide.html |
98+
| Vue | https://vuejs.org/v2/style-guide/ |
10799

build.gradle

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ buildscript {
2626
}
2727

2828
plugins {
29-
id "com.github.hierynomus.license" version "0.14.0"
30-
id "com.moowork.node" version "1.1.0"
29+
id "com.github.hierynomus.license" version "0.16.1"
3130
id "java"
3231
id "eclipse"
3332
id "idea"

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ hibernateValidatorVersion=6.0.13.Final
66
jsonWebTokenVersion=0.9.0
77
jsonWebTokenApiVersion=0.10.5
88
jsonWebTokenImplVersion=0.10.5
9-
lombokVersion=1.18.10
9+
lombokVersion=1.18.26
1010
pageHelperVersion=1.2.4
1111
mockitoVersion=2.8.47
1212
guavaVersion=21.0

0 commit comments

Comments
 (0)