RANGER-5411: Refactor logic to use external Key as MasterKey to avoid… #747
+44
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RangerMasterKey had redundant method to use external cryptographic key as MasterKey. One was written to be called from Luna-HSM and other was for SafenetKeySecure. Following methods were doing exactly same .
Also, in other implementations like RangerHSM and RangerSafenetKeySecure, there were methods to set external as MasterKey.
Idea is to unify this at super type interface level. and remove redundant method and reuse the code.
How was this patch tested?
-mvn build
-Unit test cases
This is refactoring and unifying to interface. UT cases are there for these classes and all UTs were passed.