Skip to content

Commit 01deef8

Browse files
authored
csharp: Add using to wrap HMACSHA1 instance (#582)
* csharp: Add using for HMACSHA1 Signed-off-by: catcherwong <catcher_hwq@outlook.com> * fix dotnet-format error Signed-off-by: catcherwong <catcher_hwq@outlook.com> --------- Signed-off-by: catcherwong <catcher_hwq@outlook.com>
1 parent 1e7aa33 commit 01deef8

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

csharp/rocketmq-client-csharp/Signature.cs

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,17 @@ public static Dictionary<string, string> Sign(Client client)
5959

6060
var secretData = Encoding.ASCII.GetBytes(credentials.AccessSecret);
6161
var data = Encoding.ASCII.GetBytes(time);
62-
var signer = new HMACSHA1(secretData);
63-
var digest = signer.ComputeHash(data);
64-
var hmac = BitConverter.ToString(digest).Replace("-", "");
65-
var authorization = $"{MetadataConstants.AlgorithmKey} " +
66-
$"{MetadataConstants.CredentialKey}={credentials.AccessKey}, " +
67-
$"{MetadataConstants.SignedHeadersKey}={MetadataConstants.DateTimeKey}, " +
68-
$"{MetadataConstants.SignatureKey}={hmac}";
69-
dictionary.Add(MetadataConstants.Authorization, authorization);
70-
return dictionary;
62+
using (var signer = new HMACSHA1(secretData))
63+
{
64+
var digest = signer.ComputeHash(data);
65+
var hmac = BitConverter.ToString(digest).Replace("-", "");
66+
var authorization = $"{MetadataConstants.AlgorithmKey} " +
67+
$"{MetadataConstants.CredentialKey}={credentials.AccessKey}, " +
68+
$"{MetadataConstants.SignedHeadersKey}={MetadataConstants.DateTimeKey}, " +
69+
$"{MetadataConstants.SignatureKey}={hmac}";
70+
dictionary.Add(MetadataConstants.Authorization, authorization);
71+
return dictionary;
72+
}
7173
}
7274
}
7375
}

0 commit comments

Comments
 (0)