From e0cde671095f499881aff688224910238b860c9f Mon Sep 17 00:00:00 2001 From: Martin Grund Date: Tue, 9 Jul 2024 04:31:54 +0200 Subject: [PATCH] [SPARK-48754] Address comments (#31) --- spark/client/channel/channel.go | 10 +++++----- spark/sql/session/sparksession.go | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/spark/client/channel/channel.go b/spark/client/channel/channel.go index d0b0394..3d2e246 100644 --- a/spark/client/channel/channel.go +++ b/spark/client/channel/channel.go @@ -62,23 +62,23 @@ type BaseBuilder struct { headers map[string]string } -func (cb BaseBuilder) Host() string { +func (cb *BaseBuilder) Host() string { return cb.host } -func (cb BaseBuilder) Port() int { +func (cb *BaseBuilder) Port() int { return cb.port } -func (cb BaseBuilder) Token() string { +func (cb *BaseBuilder) Token() string { return cb.token } -func (cb BaseBuilder) User() string { +func (cb *BaseBuilder) User() string { return cb.user } -func (cb BaseBuilder) Headers() map[string]string { +func (cb *BaseBuilder) Headers() map[string]string { return cb.headers } diff --git a/spark/sql/session/sparksession.go b/spark/sql/session/sparksession.go index 8a45fb0..a68b69b 100644 --- a/spark/sql/session/sparksession.go +++ b/spark/sql/session/sparksession.go @@ -51,7 +51,7 @@ func (s *SparkSessionBuilder) Remote(connectionString string) *SparkSessionBuild return s } -func (s *SparkSessionBuilder) ChannelBuilder(cb channel.Builder) *SparkSessionBuilder { +func (s *SparkSessionBuilder) WithChannelBuilder(cb channel.Builder) *SparkSessionBuilder { s.channelBuilder = cb return s }