Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skipDuringIncrementalBuild option to enhance goal #229

Closed
reckart opened this issue May 22, 2023 · 0 comments
Closed

Add skipDuringIncrementalBuild option to enhance goal #229

reckart opened this issue May 22, 2023 · 0 comments
Assignees
Milestone

Comments

@reckart
Copy link
Member

reckart commented May 22, 2023

Is your feature request related to a problem? Please describe.
The enhance goal makes modifications to the generated class files. In the best case, this triggers a second incremental build in which the class files are then detected as already processed. However, in the worst case (and for yet unknown reasons) it could lead to an endless build - possibly because the respective class files are regenerated as part of the second build causing the enhancements to be removed.

Describe the solution you'd like
An option to disable the goal during incremental builds in cases where it is problematic would be helpful.

Describe alternatives you've considered

  • Generally disable the goal for incremental builds.

Additional context
Would help with #227

@reckart reckart self-assigned this May 22, 2023
@reckart reckart added this to the 3.4.1 milestone May 22, 2023
reckart added a commit that referenced this issue Jul 5, 2023
#228 - Add skip parameter

- Added skip and skipDuringIncrementalBuild options to both the enhance and generate goals
reckart added a commit that referenced this issue Jul 5, 2023
…ntalBuild-option-to-enhance-goal

#229 - Add skipDuringIncrementalBuild option to enhance goal and #228 - Add skip parameter
@reckart reckart closed this as completed Jul 5, 2023
@reckart reckart modified the milestones: 3.4.1, 3.5.0 Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant