Skip to content

Commit 8f3c09e

Browse files
authored
Merge pull request #82 from GM-NN/non_negative_weights
Allow 0 weights in los config for grid searches
2 parents c5d5572 + caa0b00 commit 8f3c09e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

gmnn_jax/config/train_config.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from typing import List, Literal, Optional
33

44
import yaml
5-
from pydantic import BaseModel, Extra, PositiveFloat, PositiveInt
5+
from pydantic import BaseModel, Extra, NonNegativeFloat, PositiveFloat, PositiveInt
66

77

88
class DataConfig(BaseModel):
@@ -47,7 +47,7 @@ class DataConfig(BaseModel):
4747
valid_batch_size: PositiveInt = 100
4848
shuffle_buffer_size: PositiveInt = 1000
4949

50-
energy_regularisation: PositiveFloat = 1.0
50+
energy_regularisation: NonNegativeFloat = 1.0
5151

5252

5353
class ModelConfig(BaseModel, extra=Extra.forbid):
@@ -67,7 +67,7 @@ class ModelConfig(BaseModel, extra=Extra.forbid):
6767

6868
n_basis: PositiveInt = 7
6969
n_radial: PositiveInt = 5
70-
r_min: PositiveFloat = 0.5
70+
r_min: NonNegativeFloat = 0.5
7171
r_max: PositiveFloat = 6.0
7272

7373
nn: List[PositiveInt] = [512, 512]
@@ -144,7 +144,7 @@ class LossConfig(BaseModel, extra=Extra.forbid):
144144

145145
name: str
146146
loss_type: str = "molecules"
147-
weight: PositiveFloat = 1.0
147+
weight: NonNegativeFloat = 1.0
148148

149149

150150
class CallbackConfig(BaseModel, frozen=True, extra=Extra.allow):

0 commit comments

Comments
 (0)