test(metadata): add more tests

Author: aegypius

src/OpenApi/Factory/OpenApiFactory.php

@@ -337,14 +337,19 @@ private function collectPaths(ApiResource $resource, ResourceMetadataCollection
                 }
 
                 $in = $p instanceof HeaderParameterInterface ? 'header' : 'query';
+                $defaultSchema = ['type' => 'string'];
+                if (null !== $p->getDefault()) {
+                    $defaultSchema['default'] = $p->getDefault();
+                }
+
                 $defaultParameter = new Parameter(
                     $key,
                     $in,
                     $p->getDescription() ?? "$resourceShortName $key",
                     $p->getRequired() ?? false,
                     false,
                     null,
-                    $p->getSchema() ?? ['type' => 'string'],
+                    $p->getSchema() ?? $defaultSchema,
                 );
 
                 $linkParameter = $p->getOpenApi();

src/State/Provider/ParameterProvider.php

@@ -128,7 +128,7 @@ private function handlePathParameters(HttpOperation $operation, array $uriVariab
                 unset($uriVariable->getExtraProperties()['_api_values']);
             }
 
-            if (($default = $uriVariable->getDefault()  ?? false) && ($value instanceof ParameterNotFound || !$value)) {
+            if (($default = $uriVariable->getDefault() ?? false) && ($value instanceof ParameterNotFound || !$value)) {
                 $value = $default;
             }
 

src/Symfony/Bundle/Resources/config/jsonld.php

@@ -42,7 +42,7 @@
             '%api_platform.serializer.default_context%',
             service('api_platform.security.resource_access_checker')->ignoreOnInvalid(),
             service('api_platform.http_cache.tag_collector')->ignoreOnInvalid(),
-            service('api_platform.metadata.operation.metadata_factory')->ignoreOnInvalid()
+            service('api_platform.metadata.operation.metadata_factory')->ignoreOnInvalid(),
         ])
         ->tag('serializer.normalizer', ['priority' => -890]);
 

tests/Fixtures/TestBundle/ApiResource/WithParameter.php

@@ -294,6 +294,10 @@
         'foo_as_default' => new QueryParameter(
             default: 'foo',
         ),
+        'required_with_a_default' => new QueryParameter(
+            required: true,
+            default: 'bar'
+        ),
     ],
     provider: [self::class, 'checkParameterDefaults'],
 )]
@@ -393,6 +397,7 @@ public static function checkParameterDefaults(Operation $operation, array $uriVa
         Assertion::false($operation->getParameters()->get('false_as_default')->getValue());
         Assertion::true($operation->getParameters()->get('true_as_default')->getValue());
         Assertion::same($operation->getParameters()->get('foo_as_default')->getValue(), 'foo');
+        Assertion::same($operation->getParameters()->get('required_with_a_default')->getValue(), 'bar');
 
         return new JsonResponse([]);
     }