Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check CI status on master branch in release workflow #469

Open
janbuchar opened this issue Aug 27, 2024 · 5 comments
Open

Check CI status on master branch in release workflow #469

janbuchar opened this issue Aug 27, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@janbuchar
Copy link
Collaborator

More details in #466 (comment)

@janbuchar janbuchar added enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team. labels Aug 27, 2024
@vdusek
Copy link
Collaborator

vdusek commented Sep 19, 2024

We should also publish a new version of documentation after release (and updated changelog).

@janbuchar
Copy link
Collaborator Author

@vdusek
Copy link
Collaborator

vdusek commented Oct 23, 2024

How does it work exactly? Does it verify if the "code checks" for the current commit are already passing, and if they are, it proceeds? If they are not, does it trigger them ?

@janbuchar
Copy link
Collaborator Author

How does it work exactly? Does it verify if the "code checks" for the current commit are already passing, and if they are, it proceeds? If they are not, does it trigger them ?

The checks are triggerred from a separate workflow that is started on push to master. The action periodically inspects them, fails if one of them fails, succeeds if they all succeed, and keeps waiting if they are not finished. Triggering the checks from the release workflow should not be necessary.

@vdusek
Copy link
Collaborator

vdusek commented Oct 23, 2024

Thanks. It looks great then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

2 participants