fix: Do not persist storage when it is configured #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
janbuchar
requested changes
Oct 1, 2024
| @@ -57,7 +62,7 @@ def get_storage_client(*, client_type: StorageClientType | None = None) -> BaseS | |||
| return _services['cloud_storage_client'] | |||
|
|
|||
| if 'local_storage_client' not in _services: | |||
| _services['local_storage_client'] = MemoryStorageClient() | |||
| _services['local_storage_client'] = MemoryStorageClient(configuration=configuration) | |||
There was a problem hiding this comment.
What if there is a local_storage_client with a different configuration though? I'm afraid we'll need some changes on an architectural level...
There was a problem hiding this comment.
why do we even store those two separately? those should be two flavors of a single service, not two different services, at least that's how it was designed in the js version.
There was a problem hiding this comment.
If you mean why we have a separate local_storage_client and cloud_storage_client, we do this so that the force_cloud switch in the SDK works. In the JS SDK, the Actor class holds the cloud client. This feels more readable to me.
janbuchar
reviewed
Oct 1, 2024
vdusek
force-pushed
the
fix-configuration-argument
branch
from
8cebe25
to
17595f3
Compare
vdusek
force-pushed
the
fix-configuration-argument
branch
from
17595f3
to
bf000e4
Compare
vdusek
force-pushed
the
fix-configuration-argument
branch
from
bf000e4
to
e49a7ae
Compare
vdusek
changed the title
vdusek
modified the milestones:
99th sprint - Tooling team,
101st sprint - Tooling team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #539