Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a custom URL type instead of rely on httpx.URL #630

Open
vdusek opened this issue Oct 29, 2024 · 3 comments
Open

Add a custom URL type instead of rely on httpx.URL #630

vdusek opened this issue Oct 29, 2024 · 3 comments
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@vdusek
Copy link
Collaborator

vdusek commented Oct 29, 2024

@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. debt Code quality improvement or decrease of technical debt. labels Oct 29, 2024
@janbuchar
Copy link
Collaborator

A Pydantic type wouldn't probably help us much, those are typically just for validation/serialization.

@vdusek
Copy link
Collaborator Author

vdusek commented Nov 1, 2024

This new type could potentially be used more widely throughout the project, including in the Request model. It could also offer setters for managing query parameters and other attributes. Additionally, it might replace some of our existing URL-related helpers in _utils/urls.py and parts of _utils/requests.py, such as the URL normalization.

@janbuchar
Copy link
Collaborator

We might also want to use something like https://github.com/aio-libs/yarl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

2 participants