Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript Support #32

Closed
Ricerob opened this issue Mar 20, 2023 · 2 comments · Fixed by #37
Closed

TypeScript Support #32

Ricerob opened this issue Mar 20, 2023 · 2 comments · Fixed by #37

Comments

@Ricerob
Copy link

Ricerob commented Mar 20, 2023

I'm using the code from this library in a TypeScript/ Deno environment. It'd be nice if there was a possible TS implementation. If not, I can take a shot at it! I have a rough, typed implementation. Let me know what you think and how I can test/ help implement this.
@j6k4m8
Copy link
Member

j6k4m8 commented Mar 20, 2023

Hi @Ricerob!! So glad to hear the project has been helpful to you! Would love to merge a TS contribution if you are willing to make one, as long as we can still compile it down to share on npm as a JS library for JS users! ...just haven't had the engineering bandwidth to do myself... Super excited to see!

@Ricerob
Copy link
Author

Ricerob commented Mar 20, 2023

Thanks @j6k4m8 ! I'm super new to TypeScript and packaging modules.. any chance you could point me in the right direction for something like this?

@Ha-limLee Ha-limLee mentioned this issue Sep 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added type declarations Ha-limLee/npyjs
2 participants
@j6k4m8 @Ricerob