First commit #1
Open
First commit #1
+253
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boztopuz
suggested changes
Feb 18, 2025
|
|
||
| ## Required Inputs | ||
|
|
||
| - `AC_TESTINIUM_APP_PATH`: Full path of the build. For example $AC_EXPORT_DIR/Myapp.ipa. |
There was a problem hiding this comment.
Same suggestion here:
Suggested change
| - `AC_TESTINIUM_APP_PATH`: Full path of the build. For example $AC_EXPORT_DIR/Myapp.ipa. | |
| - `AC_TESTINIUM_APP_PATH`: Full path of the build. For example $AC_OUTPUT_DIR/MyApp.ipa. |
| - `AC_TESTINIUM_PROJECT_ID`: Testinium project ID. | ||
| - `AC_TESTINIUM_COMPANY_ID`: Testinium company ID. | ||
| - `AC_TESTINIUM_TIMEOUT`: Testinium plan timeout in minutes. | ||
| - `AC_TESTINIUM_MAX_API_RETRY_COUNT`: Determine max repetition in case of Testinium platform congestion or API errors. |
There was a problem hiding this comment.
When I searched briefly, the word retry is used more often in the sense of repeating a connection again. The word repetition is used in the sense of repeating something as independently error. Example usages
If the connection fails, the system will retry after 5 seconds.
Learning a new language requires constant repetition.
Suggested change
| - `AC_TESTINIUM_MAX_API_RETRY_COUNT`: Determine max repetition in case of Testinium platform congestion or API errors. | |
| - `AC_TESTINIUM_MAX_API_RETRY_COUNT`: Determine max retry in case of Testinium platform congestion or API errors. |
| defaultValue: "$AC_TESTINIUM_APP_PATH" | ||
| isRequired: true | ||
| title: Path of the build | ||
| description: "Full path of the build file. Example for iOS: `$AC_EXPORT_DIR/MyApp.ipa`. Example for Android: `$AC_APK_PATH`." |
There was a problem hiding this comment.
Same suggestion;
Suggested change
| description: "Full path of the build file. Example for iOS: `$AC_EXPORT_DIR/MyApp.ipa`. Example for Android: `$AC_APK_PATH`." | |
| description: "Full path of the build file. Example for iOS: `$AC_OUTPUT_DIR/MyApp.ipa`. Example for Android: `$AC_APK_PATH`." |
| defaultValue: "4" | ||
| isRequired: true | ||
| title: Testinium Maximum API Repetition Count | ||
| description: "Determine max repetition in case of Testinium platform congestion or API errors." |
There was a problem hiding this comment.
Suggested change
| description: "Determine max repetition in case of Testinium platform congestion or API errors." | |
| description: "Determine max retry in case of Testinium platform congestion or API errors." |
| - key: "AC_TESTINIUM_MAX_API_RETRY_COUNT" | ||
| defaultValue: "4" | ||
| isRequired: true | ||
| title: Testinium Maximum API Repetition Count |
There was a problem hiding this comment.
Suggested change
| title: Testinium Maximum API Repetition Count | |
| title: Testinium Maximum API Request Retry Count |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.