Add createdAt and metadata to container, network, and volume resources #870
+159
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alex-trm <alex.kennedy@trmlabs.com>
createdAt getter Signed-off-by: alex-trm <alex.kennedy@trmlabs.com>
Author
|
@jglogan for your consideration :) |
solventak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #791 , #665
Type of Change
Motivation and Context
Add createdAt metadata (generic metadata struct) for each Container, Volume, and Network as well as output in
lscommands to display it.Also fixes a bug when spawning
networkvmnet.servicewhere instead of initializing the network configuration from the stored information ofNetworkConfigurationentity it would create a new configuration based on key metadata that was passed in through args.Testing