Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant initializer from HTTPResponseCompressor in next major version #226

Open
dimitribouniol opened this issue Jul 18, 2024 · 0 comments

Comments

@dimitribouniol
Copy link
Contributor

dimitribouniol commented Jul 18, 2024

As mentioned, public convenience init(initialByteBufferCapacity: Int) is now redundant, but has been left in purely for backwards compatibility when referring to the initializer directly rather than calling it, and can be removed in a future major version:

/// Initialize a ``HTTPResponseCompressor``.
/// - Parameter initialByteBufferCapacity: Initial size of buffer to allocate when hander is first added.
public convenience init(initialByteBufferCapacity: Int = 1024) {
// TODO: This version is kept around for backwards compatibility and should be merged with the signature below in the next major version: https://github.com/apple/swift-nio-extras/issues/226
self.init(initialByteBufferCapacity: initialByteBufferCapacity, responseCompressionPredicate: nil)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant