-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing instructions in client examples to start the local server #702
Comments
Thanks @brentvegafederal for reporting this - we somehow forgot to document that you need to spin up e.g. https://github.com/apple/swift-openapi-generator/tree/main/Examples/hello-world-vapor-server-example in a separate tab first. Would you mind updating that README.md in both the URLSession and AHC example? |
I am happy to update the docs, but I'm not quite sure how you want them updated because spinning up Vapor to run the URLSession or AHC example doesn't make sense. |
It's a pre-requisite of running the client example. We need a server to connect to, and the Vapor and Hummingbird examples are compatible servers you can connect to. We should just mention it there, to avoid confusion of why the client examples don't work out of the box. |
Ok, got it, I'll add something about it. |
Each of the client examples does include this already:
Is that enough without having to duplicate the information from each of the server examples? |
Whoops that's my fault, I also missed that line in the README and recommended we add it, sorry. |
Question
I'm trying to start an example server or get through some of the examples, but everything end up throwing an error. Any ideas?
The text was updated successfully, but these errors were encountered: