Skip to content

Commit cb621a1

Browse files
authored
Merge pull request #724 from tbkka/tbkka-swift41-linux
Suppress known-broken test on Swift Linux 4.1 and earlier
2 parents fc41605 + ca156d4 commit cb621a1

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Tests/SwiftProtobufTests/Test_JSON.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -639,10 +639,10 @@ class Test_JSON: XCTestCase, PBTestHelpers {
639639
}
640640

641641
func testOptionalString_controlCharacters() {
642-
// This is known to fail on Swift Linux 4.0 and earlier,
642+
// This is known to fail on Swift Linux 4.1 and earlier,
643643
// so skip it there.
644644
// See https://bugs.swift.org/browse/SR-4218 for details.
645-
#if !os(Linux) || swift(>=4.1)
645+
#if !os(Linux) || swift(>=4.2)
646646
// Verify that all C0 controls are correctly escaped
647647
assertJSONEncode("{\"optionalString\":\"\\u0000\\u0001\\u0002\\u0003\\u0004\\u0005\\u0006\\u0007\"}") {(o: inout MessageTestType) in
648648
o.optionalString = "\u{00}\u{01}\u{02}\u{03}\u{04}\u{05}\u{06}\u{07}"

Tests/SwiftProtobufTests/Test_TextFormat_proto3.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -596,10 +596,10 @@ class Test_TextFormat_proto3: XCTestCase, PBTestHelpers {
596596
}
597597

598598
func testEncoding_optionalString_controlCharacters() throws {
599-
// This is known to fail on Swift Linux 4.0 and earlier,
599+
// This is known to fail on Swift Linux 4.1 and earlier,
600600
// so skip it there.
601601
// See https://bugs.swift.org/browse/SR-4218 for details.
602-
#if !os(Linux) || swift(>=4.1)
602+
#if !os(Linux) || swift(>=4.2)
603603
assertTextFormatEncode("optional_string: \"\\001\\002\\003\\004\\005\\006\\007\"\n") {
604604
(o: inout MessageTestType) in
605605
o.optionalString = "\u{01}\u{02}\u{03}\u{04}\u{05}\u{06}\u{07}"

0 commit comments

Comments
 (0)