Skip to content

Commit 5795dad

Browse files
committed
- r again use MapBuilder instead of Map.ofEntries which is too high API
1 parent a608c08 commit 5795dad

File tree

2 files changed

+26
-28
lines changed

2 files changed

+26
-28
lines changed

approvaltests-tests/src/test/java/org/approvaltests/inline/InlineApprovalsTest.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,11 @@ void testSemiAutomaticMessage()
184184
41
185185
***** DELETE ME TO APPROVE *****
186186
""";
187-
var options = new Options().inline(expected, InlineOptions.semiAutomatic());
188187
try
189188
{
189+
var options = new Options().inline(expected, InlineOptions.semiAutomatic());
190+
InlineJavaReporter reporter = (InlineJavaReporter) options.getReporter();
191+
reporter.reporter = new QuietReporter();
190192
Approvals.verify("41", options);
191193
}
192194
catch (Throwable e)
@@ -198,11 +200,11 @@ void testSemiAutomaticMessage()
198200
void testSemiAutomaticWithPreviousApproved()
199201
{
200202
var expected = """
201-
42
202-
***** DELETE ME TO APPROVE *****
203-
vvvvv PREVIOUS RESULT vvvvv
204-
41
205-
""";
203+
42
204+
***** DELETE ME TO APPROVE *****
205+
vvvvv PREVIOUS RESULT vvvvv
206+
41
207+
""";
206208
var options = new Options().inline(expected, InlineOptions.semiAutomaticWithPreviousApproved());
207209
try
208210
{

approvaltests/src/main/java/org/approvaltests/reporters/EnvironmentVariableReporter.java

Lines changed: 18 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package org.approvaltests.reporters;
22

33
import com.spun.util.ClassUtils;
4+
import com.spun.util.MapBuilder;
45
import org.approvaltests.core.ApprovalFailureReporter;
56
import org.approvaltests.reporters.intellij.IntelliJReporter;
67
import org.approvaltests.reporters.linux.MeldMergeReporter;
@@ -16,28 +17,23 @@
1617
public class EnvironmentVariableReporter implements ApprovalFailureReporter
1718
{
1819
private final ApprovalFailureReporter reporter;
19-
private static final Map<String, Class<? extends ApprovalFailureReporter>> REPORTER_MAP = Map
20-
.ofEntries(Map.entry("AraxisMergeReporter", AraxisMergeReporter.class),
21-
Map.entry("AutoApproveReporter", AutoApproveReporter.class),
22-
Map.entry("AutoApproveWhenEmptyReporter", AutoApproveWhenEmptyReporter.class),
23-
Map.entry("BeyondCompareReporter", BeyondCompareReporter.class),
24-
Map.entry("ClipboardReporter", ClipboardReporter.class),
25-
Map.entry("CodeCompareReporter", CodeCompareReporter.class),
26-
Map.entry("DelayedClipboardReporter", DelayedClipboardReporter.class),
27-
Map.entry("DiffMergeReporter", DiffMergeReporter.class), Map.entry("DiffReporter", DiffReporter.class),
28-
Map.entry("FileCaptureReporter", FileCaptureReporter.class),
29-
Map.entry("ImageReporter", ImageReporter.class), Map.entry("ImageWebReporter", ImageWebReporter.class),
30-
Map.entry("IntelliJReporter", IntelliJReporter.class), Map.entry("JunitReporter", JunitReporter.class),
31-
Map.entry("KDiff3Reporter", KDiff3Reporter.class),
32-
Map.entry("KaleidoscopeDiffReporter", KaleidoscopeDiffReporter.class),
33-
Map.entry("MeldMergeReporter", MeldMergeReporter.class),
34-
Map.entry("P4MergeReporter", P4MergeReporter.class), Map.entry("PitReporter", PitReporter.class),
35-
Map.entry("QuietReporter", QuietReporter.class), Map.entry("TestNgReporter", TestNgReporter.class),
36-
Map.entry("TextWebReporter", TextWebReporter.class), Map.entry("TkDiffReporter", TkDiffReporter.class),
37-
Map.entry("TortoiseDiffReporter", TortoiseDiffReporter.class),
38-
Map.entry("VisualStudioCodeReporter", VisualStudioCodeReporter.class),
39-
Map.entry("WinMergeReporter", WinMergeReporter.class),
40-
Map.entry("WindowsDiffReporter", WindowsDiffReporter.class));
20+
private static final Map<String, Class<? extends ApprovalFailureReporter>> REPORTER_MAP = new MapBuilder(
21+
"AraxisMergeReporter", AraxisMergeReporter.class).and("AutoApproveReporter", AutoApproveReporter.class)
22+
.and("AutoApproveWhenEmptyReporter", AutoApproveWhenEmptyReporter.class)
23+
.and("BeyondCompareReporter", BeyondCompareReporter.class).and("ClipboardReporter", ClipboardReporter.class)
24+
.and("CodeCompareReporter", CodeCompareReporter.class)
25+
.and("DelayedClipboardReporter", DelayedClipboardReporter.class)
26+
.and("DiffMergeReporter", DiffMergeReporter.class).and("DiffReporter", DiffReporter.class)
27+
.and("FileCaptureReporter", FileCaptureReporter.class).and("ImageReporter", ImageReporter.class)
28+
.and("ImageWebReporter", ImageWebReporter.class).and("IntelliJReporter", IntelliJReporter.class)
29+
.and("JunitReporter", JunitReporter.class).and("KDiff3Reporter", KDiff3Reporter.class)
30+
.and("KaleidoscopeDiffReporter", KaleidoscopeDiffReporter.class)
31+
.and("MeldMergeReporter", MeldMergeReporter.class).and("P4MergeReporter", P4MergeReporter.class)
32+
.and("PitReporter", PitReporter.class).and("QuietReporter", QuietReporter.class)
33+
.and("TestNgReporter", TestNgReporter.class).and("TextWebReporter", TextWebReporter.class)
34+
.and("TkDiffReporter", TkDiffReporter.class).and("TortoiseDiffReporter", TortoiseDiffReporter.class)
35+
.and("VisualStudioCodeReporter", VisualStudioCodeReporter.class)
36+
.and("WinMergeReporter", WinMergeReporter.class).and("WindowsDiffReporter", WindowsDiffReporter.class);
4137
public static final String ENVIRONMENT_VARIABLE_NAME = "APPROVAL_TESTS_USE_REPORTER";
4238
public static Function1<String, String> ENVIRONMENT_VARIABLES = System::getenv;
4339
public static final EnvironmentVariableReporter INSTANCE = new EnvironmentVariableReporter();

0 commit comments

Comments
 (0)