Approval test framework throws error when using it with @TestTemplate

[pbaeck]

When I use the Approvals Libary with the TestTemplate Option, like:

@TestTemplate
@ExtendWith(UserIdGeneratorTestInvocationContextProvider.class)
public void whenUserIdRequested_thenUserIdIsReturnedInCorrectFormat(UserIdGeneratorTestCase testCase) {
    UserIdGenerator userIdGenerator = new UserIdGeneratorImpl(testCase.isFeatureEnabled());

    String actualUserId = userIdGenerator.generate(testCase.getFirstName(), testCase.getLastName());

    Assertions.assertEquals(actualUserId, testCase.getExpectedUserId());
    Approvals.verify(actualUserId);
}

It throws the error:

java.lang.RuntimeException: Could not find Junit/TestNg TestCase you are running, supported frameworks: Junit3, Junit4, Junit5, TestNg

The problem is in the function:
org.approvaltests.namer.AttributeStackSelector > AttributeStackSelector (Class is not TestCase when using @testtemplate)

Is there a possibility to use the libary with @testtemplate?

[LarsEckart]

This sounds similar to #171 and I have to admit, that one gave us some trouble. :)

We'll look into it, perhaps already next Monday when we meet again.

[LarsEckart]

hello @pbaeck !

getting to a compiling example took us some time, but once we had it, implementing initial support for @testtemplate wasn't too difficult. Have a look at this:

https://github.com/approvals/ApprovalTests.Java/blob/issue-174/approvaltests/src/test/java/org/approvaltests/namer/TestTemplateTest.java#L38

We don't use ApprovalTests there but the resulting string is what ApprovalTests will use as file name for each of the test cases.

What do you think, shall we publish this?

[pbaeck]

Hi Lars,

thank you for your fast response.
I think that will resolve my problem.

I'm looking foward for the new version :)