Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch arguments to diff-tool #26

Open
roesslerj opened this issue Jun 28, 2016 · 2 comments
Open

Switch arguments to diff-tool #26

roesslerj opened this issue Jun 28, 2016 · 2 comments

Comments

@roesslerj
Copy link

Currently, the diff-tool is called with arguments: .received. .approved., causing the expected result to be on the right side of the merge/diff-tool. Default is that the expected result is to the left.

Could the order of the arguments be switched, so the approved result shows up on the left?

Great! Thanks!

@isidore
Copy link
Member

isidore commented Jun 28, 2016

No. Many of the diff tools will not let you move changes from right to
left. Since the approved file is often created in the diff tool by moving
the results you got to the approved side reversing the order is problematic.

Llewellyn Falco
www.approvaltests.com

On Tue, Jun 28, 2016 at 2:46 PM, Jeremias Rößler notifications@github.com
wrote:

Currently, the diff-tool is called with arguments: .received.
.approved., causing the expected result to be on the right side of the
merge/diff-tool. Default is that the expected result is to the left.

Could the order of the arguments be switched, so the approved result shows
up on the left?

Great! Thanks!


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#26, or mute the
thread
https://github.com/notifications/unsubscribe/AAAqehO3qQh1u8ddvVXc6VcaghYVZRNPks5qQWvrgaJpZM4JAaQR
.

@roesslerj
Copy link
Author

Thanks for the fast feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants