Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rack EventHandler should listen to appsignal.action #1102

Closed
tombruijn opened this issue Jun 19, 2024 · 1 comment
Closed

Rack EventHandler should listen to appsignal.action #1102

tombruijn opened this issue Jun 19, 2024 · 1 comment
Assignees
@tombruijn
Labels
enhancement

Comments

@tombruijn
Copy link
Member

Same as the GenericInstrumentation or the AbstractMiddleware (from PR #1101). Make it so that the EventHandler can be used on its own.
@tombruijn tombruijn self-assigned this Jun 19, 2024
@tombruijn tombruijn changed the title Rack EventHandler should listen to appsignal.route and/or appsignal.action Rack EventHandler should listen to appsignal.action Jun 21, 2024
@tombruijn
Copy link
Member Author

With the different nesting of middlewares, I think it's better to suggest using Appsignal.set_action, because that sets the action name directly and appsignal.action would set it after other middlewares. Because we will want to use set_action_if_nil, that means it will be ignored.

@tombruijn tombruijn closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tombruijn tombruijn

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tombruijn