Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sinatra applications wrapped in many middleware loses Sinatra config #157

Closed
tombruijn opened this issue Sep 16, 2016 · 5 comments
Closed

Sinatra applications wrapped in many middleware loses Sinatra config #157

tombruijn opened this issue Sep 16, 2016 · 5 comments
Labels
bug

Comments

@tombruijn
Copy link
Member

See PR #156 and comment #156 (comment)
@tombruijn tombruijn added the bug label Sep 16, 2016
@jeffkreeftmeijer jeffkreeftmeijer self-assigned this Sep 19, 2016
@wesoudshoorn
Copy link
Member

@tombruijn can you give your opinion on wether we should fix this issue or ignore because it's a rare occurrence?

@tombruijn
Copy link
Member Author

Well it's really @jeffkreeftmeijer's issue ;)

But yes I think it's an important issue and could be quite common. Sinatra apps with multiple middlewares where AppSignal is not loaded first lose part of their config. So we're changing the behavior of Sinatra apps without the user knowing. That's something we should never do. Previously this raised an error, now we're hiding it, but it should still be fixed.

@thijsc
Copy link
Member

thijsc commented Feb 20, 2017

Is this related to #149?

@tombruijn
Copy link
Member Author

No it's a different issue unfortunately

@tombruijn tombruijn added this to the 2.3 milestone Mar 8, 2017
@tombruijn tombruijn modified the milestones: Ruby gem 2.4, Ruby gem 2.3 Jun 16, 2017
@tombruijn
Copy link
Member Author

We might be able to review/fix this in #329

@tombruijn tombruijn changed the title Sinatra applications wrapped in many middleware loses Sinatra config 🐞 Sinatra applications wrapped in many middleware loses Sinatra config Oct 27, 2017
@tombruijn tombruijn changed the title 🐞 Sinatra applications wrapped in many middleware loses Sinatra config inatra applications wrapped in many middleware loses Sinatra config May 30, 2018
@tombruijn tombruijn changed the title inatra applications wrapped in many middleware loses Sinatra config Sinatra applications wrapped in many middleware loses Sinatra config May 30, 2018
@tombruijn tombruijn removed this from the The next minor Ruby gem version milestone Jan 7, 2019
@jeffkreeftmeijer jeffkreeftmeijer closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thijsc @jeffkreeftmeijer @tombruijn @wesoudshoorn