From 896cdaf5ca3952b819b3df95eb6030e1a87ca406 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Geyslan=20Greg=C3=B3rio?= <geyslan@gmail.com>
Date: Fri, 19 Jul 2024 17:58:27 -0300
Subject: [PATCH] fix(build): parallel build (libbpf wise)

When running with -j option, the build was emitting bogus messages
related to the lack of libbpf.a. A variable was being evaluated out of
a rule and respective requirements were not being met.
---
 .gitignore |  1 +
 Makefile   | 44 +++++++++++++++++++++++++++++++++-----------
 2 files changed, 34 insertions(+), 11 deletions(-)

diff --git a/.gitignore b/.gitignore
index 322ac9b09275..b9e19516b816 100644
--- a/.gitignore
+++ b/.gitignore
@@ -23,6 +23,7 @@ compile_commands.json
 .cache*
 .trunk*
 .vagrant
+goenv.mk
 
 # binaries and build files
 dist
diff --git a/Makefile b/Makefile
index 1a26cf2325fa..d43c4b1e2b8b 100644
--- a/Makefile
+++ b/Makefile
@@ -12,6 +12,15 @@ PARALLEL = $(shell $(CMD_GREP) -c ^processor /proc/cpuinfo)
 MAKE = make
 MAKEFLAGS += --no-print-directory
 
+#
+# env
+#
+
+GOENV_MK = goenv.mk
+
+# load Go environment variables
+-include $(GOENV_MK)
+
 #
 # tools
 #
@@ -370,6 +379,21 @@ $(LIBBPF_OBJ): \
 		INCLUDEDIR= UAPIDIR= prefix= libdir= \
 		install install_uapi_headers
 
+.ONESHELL:
+$(GOENV_MK): $(LIBBPF_OBJ)
+	@{
+		$(eval GO_ENV_EBPF = )
+		$(eval GO_ENV_EBPF += GOOS=linux)
+		$(eval GO_ENV_EBPF += CC=$(CMD_CLANG))
+		$(eval GO_ENV_EBPF += GOARCH=$(GO_ARCH))
+		$(eval GO_ENV_EBPF += CGO_CFLAGS=$(CUSTOM_CGO_CFLAGS))
+
+		$(eval CUSTOM_CGO_LDFLAGS := "$(shell PKG_CONFIG_PATH=$(PKG_CONFIG_PATH) $(CMD_PKGCONFIG) $(PKG_CONFIG_FLAG) --libs $(LIB_BPF))")
+		$(eval GO_ENV_EBPF := $(GO_ENV_EBPF) CGO_LDFLAGS=$(CUSTOM_CGO_LDFLAGS))
+		export GO_ENV_EBPF=$(GO_ENV_EBPF)
+		echo 'GO_ENV_EBPF := $(GO_ENV_EBPF)' > $@
+	}
+
 $(LIBBPF_SRC): \
 	| .check_$(CMD_GIT)
 #
@@ -429,14 +453,6 @@ ifeq ($(STATIC), 1)
     PKG_CONFIG_FLAG = --static
 endif
 
-CUSTOM_CGO_LDFLAGS = "$(shell PKG_CONFIG_PATH=$(PKG_CONFIG_PATH) $(CMD_PKGCONFIG) $(PKG_CONFIG_FLAG) --libs $(LIB_BPF))"
-GO_ENV_EBPF =
-GO_ENV_EBPF += GOOS=linux
-GO_ENV_EBPF += CC=$(CMD_CLANG)
-GO_ENV_EBPF += GOARCH=$(GO_ARCH)
-GO_ENV_EBPF += CGO_CFLAGS=$(CUSTOM_CGO_CFLAGS)
-GO_ENV_EBPF += CGO_LDFLAGS=$(CUSTOM_CGO_LDFLAGS)
-
 TRACEE_PROTOS = ./api/v1beta1/*.proto
 
 #
@@ -472,6 +488,7 @@ tracee: $(OUTPUT_DIR)/tracee
 $(OUTPUT_DIR)/tracee: \
 	$(OUTPUT_DIR)/tracee.bpf.o \
 	$(TRACEE_SRC) \
+	$(GOENV_MK) \
 	| .checkver_$(CMD_GO) \
 	.checklib_$(LIB_BPF) \
 	btfhub \
@@ -504,6 +521,7 @@ tracee-ebpf: $(OUTPUT_DIR)/tracee-ebpf
 $(OUTPUT_DIR)/tracee-ebpf: \
 	$(OUTPUT_DIR)/tracee.bpf.o \
 	$(TRACEE_SRC) \
+	$(GOENV_MK) \
 	| .checkver_$(CMD_GO) \
 	.checklib_$(LIB_BPF) \
 	btfhub
@@ -537,6 +555,7 @@ tracee-rules: $(OUTPUT_DIR)/tracee-rules
 
 $(OUTPUT_DIR)/tracee-rules: \
 	$(TRACEE_RULES_SRC) \
+	$(GOENV_MK) \
 	| .checkver_$(CMD_GO) \
 	$(OUTPUT_DIR) \
 	signatures
@@ -580,6 +599,7 @@ signatures: $(OUTPUT_DIR)/signatures
 $(OUTPUT_DIR)/signatures: \
 	$(GOSIGNATURES_SRC) \
 	$(REGO_SIGNATURES_SRC) \
+	$(GOENV_MK) \
 	| .checkver_$(CMD_GO) \
 	.check_$(CMD_INSTALL) \
 	$(OUTPUT_DIR)
@@ -641,8 +661,9 @@ tracee-gptdocs: $(OUTPUT_DIR)/tracee-gptdocs
 
 $(OUTPUT_DIR)/tracee-gptdocs: \
 	$(TRACEE_GPTDOCS_SRC) \
-	$(LIBBPF_OBJ) \
+	$(GOENV_MK) \
 	| .checkver_$(CMD_GO) \
+	.checklib_$(LIB_BPF) \
 	$(OUTPUT_DIR)
 #
 	$(MAKE) $(OUTPUT_DIR)/btfhub
@@ -766,8 +787,8 @@ test-types: \
 
 .PHONY: $(OUTPUT_DIR)/syscaller
 $(OUTPUT_DIR)/syscaller: \
-	$(LIBBPF_OBJ) \
-	| .check_$(CMD_GO)
+	$(GOENV_MK) \
+	| .check_$(CMD_GO) \
 #
 	$(GO_ENV_EBPF) \
 	$(CMD_GO) build -o $(OUTPUT_DIR)/syscaller ./tests/integration/syscaller/cmd
@@ -989,6 +1010,7 @@ man: clean-man $(MAN_FILES)
 clean:
 #
 	$(CMD_RM) -rf $(OUTPUT_DIR)
+	$(CMD_RM) -f $(GOENV_MK)
 	$(CMD_RM) -f .*.md5
 	$(CMD_RM) -f .check*
 	$(CMD_RM) -f .*-pkgs*